feat(Transfer): add IsWrapItemText parameter #7057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR introduces customizable wrapping behavior and item width support to the Transfer component by adding new parameters, updating the component’s CSS classes, and exposing these controls in the demo page. Class diagram for updated Transfer component parametersclassDiagram
class Transfer {
+bool IsWrapItem = true
+bool IsWrapItemText
+string? ItemWidth
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/Transfers.razor:9-18` </location>
<code_context>
+ <section ignore class="row form-inline g-3">
</code_context>
<issue_to_address>
**nitpick:** Usage of 'ignore' attribute on section may be unnecessary.
If 'ignore' is not needed for a specific framework, please remove it to keep the markup clear.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Transfer component to improve layout flexibility and text overflow handling. The changes introduce new configuration options for item wrapping and text overflow behavior, along with adjusting default styling to be more flexible.
Key changes:
- Added new
IsWrapItemTextparameter to control text wrapping within items - Changed
IsWrapItemdefault fromfalsetotrue(breaking change) - Restructured CSS to separate item layout wrapping from text wrapping, with improved default overflow handling
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/BootstrapBlazor/Components/Transfer/TransferPanel.razor | Reformatted input and Checkbox elements for better readability (whitespace only) |
| src/BootstrapBlazor/Components/Transfer/Transfer.razor.scss | Refactored CSS to separate item wrapping from text wrapping, added default ellipsis overflow handling |
| src/BootstrapBlazor/Components/Transfer/Transfer.razor.cs | Added IsWrapItemText parameter, changed IsWrapItem default to true, updated documentation |
| src/BootstrapBlazor/Components/Transfer/Transfer.razor | Reformatted Button elements for better readability (whitespace only) |
| src/BootstrapBlazor.Server/Locales/zh-CN.json | Updated Chinese description for normal Transfer usage |
| src/BootstrapBlazor.Server/Locales/en-US.json | Updated English description for normal Transfer usage |
| src/BootstrapBlazor.Server/Components/Samples/Transfers.razor.cs | Added test variables and modified test data to include overflow test case |
| src/BootstrapBlazor.Server/Components/Samples/Transfers.razor | Added interactive controls to test new wrapping parameters |
| src/BootstrapBlazor.Server/Components/Routes.razor | Added conditional routing logic for .NET 10 compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7057 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 32532 32534 +2
Branches 4510 4510
=========================================
+ Hits 32532 32534 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7056
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable configurable wrapping behavior in the Transfer component by adding parameters for item wrapping, text wrapping, and item width, along with corresponding CSS and sample UI controls
New Features:
Enhancements: